Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix probabilility sampler #299

Merged
merged 2 commits into from Jul 20, 2020
Merged

Fix probabilility sampler #299

merged 2 commits into from Jul 20, 2020

Conversation

fbogsany
Copy link
Contributor

@fbogsany fbogsany commented Jul 19, 2020 •
edited

Fixes #298

cc @ericmustin

@fbogsany fbogsany self-assigned this Jul 19, 2020
ericmustin
ericmustin approved these changes Jul 19, 2020
View reviewed changes
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm fwiw 👍

@mwear mwear mentioned this pull request Jul 20, 2020
Merged
mwear
mwear approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting @ericmustin and thanks for fixing @fbogsany!

@mwear mwear merged commit 2499c53 into master Jul 20, 2020
@fbogsany fbogsany deleted the fix_probablility_sampler branch January 13, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwear mwear mwear approved these changes

@ericmustin ericmustin ericmustin approved these changes

@bai bai Awaiting requested review from bai

@dazuma dazuma Awaiting requested review from dazuma

@elskwid elskwid Awaiting requested review from elskwid

@luvtechno luvtechno Awaiting requested review from luvtechno

Assignees

@fbogsany fbogsany

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProbabilitySampler.sample_trace_id? should account for spec compliant trace_id
3 participants
@fbogsany @mwear @ericmustin