Add hex_trace_id and hex_span_id helpers #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbogsany
requested review from
bai,
dazuma,
elskwid,
luvtechno and
mwear
as code owners
mwear
reviewed
Aug 24, 2020
There was a problem hiding this comment.
Can we use the newly added helpers in TraceParent, here: https://github.com/open-telemetry/opentelemetry-ruby/blob/master/api/lib/opentelemetry/trace/propagation/trace_context/trace_parent.rb#L77-L89. Otherwise, LGTM.
EDIT: It looks like the answer is no, since that code will parse them from a string, or a span context.
mwear
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements open-telemetry/opentelemetry-specification#836.
Rather than rename
trace_idandspan_idtobinary_trace_idandbinary_span_id, I've left them as is and added documentation describing their format.