add a logger #62
Merged
add a logger #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indrekj
reviewed
Sep 7, 2019
api/lib/opentelemetry/logger.rb
Outdated
|
|
||
| module OpenTelemetry | ||
| class << self | ||
| attr_accessor :logger |
There was a problem hiding this comment.
would it make more sense to put it to https://github.com/open-telemetry/opentelemetry-ruby/blob/2a22a85e09a2c4823a804d71481c3e4cc606f5fd/api/lib/opentelemetry.rb which already includes similar things and it's on top level also ?
There was a problem hiding this comment.
we could for sure. I started this thinking we would subclass Logger but I didn't see any reason at the moment.
any opinions @fbogsany ?
There was a problem hiding this comment.
lets see what everyone thinks. I'm ok either way.
Closed
ibawt
requested review from
bai,
luvtechno,
mwear and
SergeyKanzhelev
as code owners
|
👀 |
mwear
approved these changes
Sep 11, 2019
fbogsany
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the design of having no runtime impact, I thnk that error conditions will end up being eaten and not reported. While I don't think the user of the library will need to handle the cases directly it'd be good know if for instance they screwed up the header for propagation etc etc.
@fbogsany