Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update context to match spec #807

Merged
merged 11 commits into from
Jun 23, 2021
Merged

fix: update context to match spec #807

merged 11 commits into from
Jun 23, 2021

Commits on Jun 23, 2021

  1. fix: update context to match spec

    @robertlaurin
    robertlaurin committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    9eb6081 View commit details
    Browse the repository at this point in the history

  2. fix: restore context value class method

    @robertlaurin
    robertlaurin committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    f25ece7 View commit details
    Browse the repository at this point in the history

  3. fix: use array to maintain context stack

    @robertlaurin
    robertlaurin committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    8f17016 View commit details
    Browse the repository at this point in the history

  4. fix: misc Francis feedback 

    Co-authored-by: Francis Bogsanyi <francis.bogsanyi@shopify.com>
    @robertlaurin @fbogsany
    robertlaurin and fbogsany committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    3fa7581 View commit details
    Browse the repository at this point in the history

  5. fix: use error handler for logging out of sync detach calls

    @robertlaurin
    robertlaurin committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    1ead432 View commit details
    Browse the repository at this point in the history

  6. fix: add detach specific error

    @robertlaurin
    robertlaurin committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    b55f632 View commit details
    Browse the repository at this point in the history

  7. fix: relax description of return type for attach detach 

    Co-authored-by: Francis Bogsanyi <francis.bogsanyi@shopify.com>
    @robertlaurin @fbogsany
    robertlaurin and fbogsany committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    98e5b7f View commit details
    Browse the repository at this point in the history

  8. fix: Efficiency concerns 

    Co-authored-by: Francis Bogsanyi <francis.bogsanyi@shopify.com>
    @robertlaurin @fbogsany
    robertlaurin and fbogsany committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    3f99c34 View commit details
    Browse the repository at this point in the history

  9. fix: failing test from efficiency fixup

    @robertlaurin
    robertlaurin committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    81d75bc View commit details
    Browse the repository at this point in the history

  10. fix: remove dead code 

    Co-authored-by: Francis Bogsanyi <francis.bogsanyi@shopify.com>
    @robertlaurin @fbogsany
    robertlaurin and fbogsany committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    f092014 View commit details
    Browse the repository at this point in the history

  11. fix: remove current setting in context clear

    @robertlaurin
    robertlaurin committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    94cd8a8 View commit details
    Browse the repository at this point in the history