Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return early if carrier is nil #835

Merged
merged 2 commits into from
Jun 23, 2021
Merged

fix: return early if carrier is nil #835

merged 2 commits into from
Jun 23, 2021

Conversation

robertlaurin
Copy link
Contributor

Received reports from users getting log messages indicating that the text map propagator was raising when trying to extract.

Error extracting W3C baggage: undefined method gsub' for nil:NilClass`

@robertlaurin robertlaurin merged commit 76ef411 into main Jun 23, 2021
@robertlaurin robertlaurin deleted the fix-baggage-textmap-extractor branch June 23, 2021 21:22
@hosamaly hosamaly mentioned this pull request Mar 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbogsany fbogsany fbogsany approved these changes

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robertlaurin @fbogsany