-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some deprecated api calls and clippy reports #74
Conversation
12dfa5a
to
1895ea0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Can you also remove the exclusion of this project from Cargo.toml, so the build can be verified. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=======================================
+ Coverage 52.3% 53.3% +1.0%
=======================================
Files 38 38
Lines 4967 5026 +59
=======================================
+ Hits 2598 2680 +82
+ Misses 2369 2346 -23 ☔ View full report in Codecov by Sentry. |
36dba2d
to
37be9ec
Compare
@funArash - There are some errors in CI build for Datadog if you can fix in this PR. Thanks. Documenting opentelemetry-datadog v0.10.0 (/home/runner/work/opentelemetry-rust-contrib/opentelemetry-rust-contrib/opentelemetry-datadog)
error: unexpected `cfg` condition value: `surf-client`
--> opentelemetry-datadog/src/exporter/mod.rs:162:21
|
162 | not(feature = "surf-client"),
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: expected values for `feature` are: `agent-sampling`, `reqwest`, `reqwest-blocking-client`, `reqwest-client`, and `surf`
= help: consider adding `surf-client` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `-D unexpected-cfgs` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unexpected_cfgs)]`
error: unexpected `cfg` condition value: `surf-client`
--> opentelemetry-datadog/src/exporter/mod.rs:168:17
|
168 | feature = "surf-client"
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: expected values for `feature` are: `agent-sampling`, `reqwest`, `reqwest-blocking-client`, `reqwest-client`, and `surf`
= help: consider adding `surf-client` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
error: unexpected `cfg` condition value: `surf-client`
--> opentelemetry-datadog/src/exporter/mod.rs:172:21
|
172 | not(feature = "surf-client"),
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: expected values for `feature` are: `agent-sampling`, `reqwest`, `reqwest-blocking-client`, `reqwest-client`, and `surf`
= help: consider adding `surf-client` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
error: could not document `opentelemetry-datadog` |
I cannot repo the errors locally.. am I missing something?
|
found it.. |
1c6d8fa
to
ac64f19
Compare
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes