Skip to content

Commit

Permalink
Remove AWSid generator (#1820)
Browse files Browse the repository at this point in the history
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
  • Loading branch information
cijothomas and TommyCpp committed May 24, 2024
1 parent 98741c7 commit 1b410d0
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 112 deletions.
15 changes: 9 additions & 6 deletions opentelemetry-sdk/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,21 @@
must now use `.with_resource(RESOURCE::default())` to configure Resource on
logger provider.
- Removed dependency on `ordered-float`.
- Removed `XrayIdGenerator`, which was marked deprecated since 0.21.3. Use
[`opentelemetry-aws`](https://crates.io/crates/opentelemetry-aws), version
0.10.0 or newer.

- **Breaking** [1726](https://github.com/open-telemetry/opentelemetry-rust/pull/1726)
Update `LogProcessor::emit() method to take mutable reference to LogData. This is breaking
change for LogProcessor developers. If the processor needs to invoke the exporter
asynchronously, it should clone the data to ensure it can be safely processed without
change for LogProcessor developers. If the processor needs to invoke the exporter
asynchronously, it should clone the data to ensure it can be safely processed without
lifetime issues. Any changes made to the log data before cloning in this method will be
reflected in the next log processor in the chain, as well as to the exporter.
- **Breaking** [1726](https://github.com/open-telemetry/opentelemetry-rust/pull/1726)
Update `LogExporter::export() method to accept a batch of log data, which can be either a
reference or owned `LogData`. If the exporter needs to process the log data
asynchronously, it should clone the log data to ensure it can be safely processed without
lifetime issues.
Update `LogExporter::export() method to accept a batch of log data, which can be either a
reference or owned`LogData`. If the exporter needs to process the log data
asynchronously, it should clone the log data to ensure it can be safely processed without
lifetime issues.

## v0.23.0

Expand Down
98 changes: 0 additions & 98 deletions opentelemetry-sdk/src/trace/id_generator/aws.rs

This file was deleted.

3 changes: 0 additions & 3 deletions opentelemetry-sdk/src/trace/id_generator/mod.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
//! Id Generator
pub(super) mod aws;

use opentelemetry::trace::{SpanId, TraceId};
use rand::{rngs, Rng, SeedableRng};
use std::cell::RefCell;
Expand Down
5 changes: 0 additions & 5 deletions opentelemetry-sdk/src/trace/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,6 @@ mod tracer;
pub use config::{config, Config};
pub use events::SpanEvents;

#[deprecated(
since = "0.21.3",
note = "XrayId Generator has been migrated to the opentelemetry-aws crate"
)]
pub use id_generator::aws::XrayIdGenerator;
pub use id_generator::{IdGenerator, RandomIdGenerator};
pub use links::SpanLinks;
pub use provider::{Builder, TracerProvider};
Expand Down

0 comments on commit 1b410d0

Please sign in to comment.