-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serialize attributes for SpanData #58
Comments
btw, do you have any thoughts on when you plan to update the crate version (since |
Hi @jodh-intel We don't have a set date for our next release to crates.io, though it has been a while and there have been a lot of changes since the last release (including moving github org). |
Thanks @MikeGoldsmith - I've tried using the latest git repo version but it got messy due to other deps (and their particular versioned deps) so would be great to be able to consume direct from crates.io ideally. @jtescher - do you think adding these serialisation options is reasonable? |
@jodh-intel yeah As far as a release, once the current open PR's land we can likely get a release ready. The current issues around how current span tracking works with futures is the real meat of the outstanding work to be done. |
Added `Serialize` and `Deserialize` attributes to allow `SpanData` to be serialized and deserialized using the `serde` crate. Also added a basic unit test for `SpanData` serialization and deserialization. Fixes: open-telemetry#58. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Added `Serialize` and `Deserialize` attributes to allow `SpanData` to be serialized and deserialized using the `serde` crate. Also added a basic unit test for `SpanData` serialization and deserialization. Fixes: open-telemetry#58. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Added `Serialize` and `Deserialize` attributes to allow `SpanData` to be serialized and deserialized using the `serde` crate. Also added a basic unit test for `SpanData` serialization and deserialization. Fixes: open-telemetry#58. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Added `Serialize` and `Deserialize` attributes to allow `SpanData` to be serialized and deserialized using the `serde` crate. Also added a basic unit test for `SpanData` serialization and deserialization. Fixes: open-telemetry#58. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Added `Serialize` and `Deserialize` attributes to allow `SpanData` to be serialized and deserialized using the `serde` crate. Also added a basic unit test for `SpanData` serialization and deserialization. Fixes: open-telemetry#58. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Added `Serialize` and `Deserialize` attributes to allow `SpanData` to be serialized and deserialized using the `serde` crate. Also added a basic unit test for `SpanData` serialization and deserialization. Fixes: open-telemetry#58. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Added `Serialize` and `Deserialize` attributes to allow `SpanData` to be serialized and deserialized using the `serde` crate. Also added a basic unit test for `SpanData` serialization and deserialization. Fixes: open-telemetry#58. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Added `Serialize` and `Deserialize` attributes to allow `SpanData` to be serialized and deserialized using the `serde` crate. Also added a basic unit test for `SpanData` serialization and deserialization. Fixes: open-telemetry#58. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Added optional `serialize` feature that allows `SpanData` to be serialized/deserialized using the `serde` crate. Also added a basic unit test for `SpanData` to test serialization and deserialization. Fixes: open-telemetry#58. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Added optional `serialize` feature that allows `SpanData` to be serialized/deserialized using the `serde` crate. Also added a basic unit test for `SpanData` to test serialization and deserialization. Fixes: open-telemetry#58. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Added optional `serialize` feature that allows `SpanData` to be serialized/deserialized using the `serde` crate. Also added a basic unit test for `SpanData` to test serialization and deserialization. Fixes: open-telemetry#58. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Added optional `serialize` feature that allows `SpanData` to be serialized/deserialized using the `serde` crate. Also added a basic unit test for `SpanData` to test serialization and deserialization. Fixes: #58. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Added optional `serialize` feature that allows `SpanData` to be serialized/deserialized using the `serde` crate. Also added a basic unit test for `SpanData` to test serialization and deserialization. Fixes: open-telemetry#58. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
I'd like to be able to serialise and deserialise the public
SpanData
[1]. Since all of its fields are public I could do that manually or even use the magic "remote derive" feature of serde [2]. However, from a safety and usability perspective adding the standard#[derive(Serialize, Deserialize)]
toSpanData
would allow standard serde semantics.[1] - kata-containers/kata-containers#60
[2] - https://serde.rs/remote-derive.html
The text was updated successfully, but these errors were encountered: