Drop include_trace_context parameter from Logs API/SDK #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1133 +/- ##
=====================================
Coverage 49.3% 49.4%
=====================================
Files 175 175
Lines 20470 20434 -36
=====================================
- Hits 10101 10100 -1
+ Misses 10369 10334 -35
☔ View full report in Codecov by Sentry. |
lalitb
changed the title
lzchen
reviewed
Jun 27, 2023
lzchen
approved these changes
Jun 27, 2023
Co-authored-by: Leighton Chen <lechen@microsoft.com>
TommyCpp
reviewed
Jul 10, 2023
Comment on lines
208
to
211
| let ctx = Context::current(); | ||
| if ctx.has_active_span() { | ||
| let span = ctx.span(); | ||
| record.trace_context = Some(span.span_context().into()); |
There was a problem hiding this comment.
Now that we merged #1140. Maybe use map_current here?
There was a problem hiding this comment.
Have resolved the merge conflicts now, and using map_current for active context.
TommyCpp
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1132
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes