Use ureq for collector instead of reqwest blocking client #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/glademiller/opentelemetry-rust into feature/opentelemetry-jaeger_use_ureq_for_collector
|
great start! looks like there a a few lint issues and signing the CLA left |
|
I don't know that I have the bandwidth right now to get this all the way
across the line so would love if someone would take this and run with it.
If not I'm sure at some indeterminate moment in the future I could try to
get it across the line.
…On Wed, May 20, 2020, 10:41 Julian Tescher ***@***.***> wrote:
great start! looks like there a a few lint issues and signing the CLA left
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#116 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPJZBHU6CBNU6P6HGSYDD3RSQB4LANCNFSM4NFDCPHA>
.
|
|
I can pick this up 👍 I'll use another branch and open up a new PR to avoid issues with the CLA. |
|
@LukeMathWalker thanks for running with this I'll close this PR |
glademiller
deleted the
feature/opentelemetry-jaeger_use_ureq_for_collector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.