Add OTLP LogExporter to the example #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
commented
Jul 27, 2023
|
|
||
| exporters: | ||
| logging: | ||
| loglevel: debug | ||
|
|
||
| jaeger: |
There was a problem hiding this comment.
this was cleaned up as the purpose of this example is to show how to use OTLP Exporter. The config will print the telemetry to stdout which is good enough to confirm things working. Even if there is a need to use Jaeger to visualize, Jaeger can natively understand OTLP, so no need to futher export from collector.
cijothomas
commented
Jul 27, 2023
| service: | ||
| extensions: [pprof, zpages, health_check] |
There was a problem hiding this comment.
removed everything unnecessary to keep the example config the the minimal.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1168 +/- ##
=====================================
Coverage 49.6% 49.6%
=====================================
Files 165 165
Lines 20522 20522
=====================================
+ Hits 10198 10199 +1
+ Misses 10324 10323 -1 ☔ View full report in Codecov by Sentry. |
lalitb
reviewed
Jul 28, 2023
lalitb
approved these changes
Jul 28, 2023
lalitb
reviewed
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1164 (comment)
Adds Logging to the OTLP examples, along with nit cleanups.