Add tracing tests using inmemoryexporter #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
TommyCpp
approved these changes
Oct 19, 2023
lalitb
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding module level tests, which tests the entire tracing api/sdk pipeline. These are not unit tests, but not integration tests either.
I think this is a good way to test things, and improve coverage. This is pretty close to testing what an end user experiences (minus the actual exporter part, which can be covered by spinning up collectors in the future.)
This was discussed in todays SIG meeting, and opening this PR to get early feedback. If all likes this direction, then I can send follow up PRs greatly improving coverage, and extend it to metrics and logs as well. (Or create issues with "help-wanted" tag inviting more folks to contribute.)
This uses in_memory_exporter which were recently added. If we ourselves don't use it, who else will 🤣 !