Fix metric export data for unused gauges #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
cijothomas
approved these changes
Nov 9, 2023
shaun-cox
approved these changes
Nov 9, 2023
TommyCpp
approved these changes
Nov 9, 2023
|
Shall do a patch release or do we want to wait a few days in case there are other bugs need to be fixed? |
|
Could be worth backporting some of the recent bug fixes as there have been a few |
|
Thanks for the quick fix! Maybe a regression test would be good? |
Absolutely! |
jtescher
added a commit
to jtescher/opentelemetry-rust-1
that referenced
this pull request
Nov 13, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1360
Changes
Clears metric data for gauges that have not received any values when aggregating.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes