Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial tests to opentelemetry-appender-log #1501

Conversation

mattbodd
Copy link
Contributor

@mattbodd mattbodd commented Jan 30, 2024

Fixes #1420

Changes

  • Added tests to opentelemetry-appender-log crate to reach 100% of function coverage and 99%+ of line coverage via cargo-llvm-cov

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@mattbodd mattbodd requested a review from a team as a code owner January 30, 2024 18:49
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3bee4e) 63.7% compared to head (a12b936) 63.7%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1501   +/-   ##
=====================================
  Coverage   63.7%   63.7%           
=====================================
  Files        144     144           
  Lines      19983   19983           
=====================================
  Hits       12741   12741           
  Misses      7242    7242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattbodd
Copy link
Contributor Author

It doesn't look like the code coverage report reflects the new tests

@cijothomas cijothomas merged commit d4a6b3e into open-telemetry:main Jan 31, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for appender-log crate
2 participants