Add warning about Log API that is it not for app users #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
commented
Jan 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
=====================================
Coverage 63.7% 63.8%
=====================================
Files 144 144
Lines 19983 19983
=====================================
+ Hits 12741 12750 +9
+ Misses 7242 7233 -9 ☔ View full report in Codecov by Sentry. |
lalitb
approved these changes
Jan 30, 2024
hdost
reviewed
Jan 31, 2024
| @@ -137,7 +137,6 @@ above, please let us know! We'd love to add your project to the list! | |||
|
|
|||
| [`open-telemetry/opentelemetry-rust`]: https://github.com/open-telemetry/opentelemetry-rust | |||
| [`opentelemetry-jaeger`]: https://crates.io/crates/opentelemetry-jaeger | |||
| [`Jaeger`]: https://www.jaegertracing.io | |||
There was a problem hiding this comment.
Not sure why you removed an associated project. They are also implementing OTLP.
There was a problem hiding this comment.
This is not the list of associated project. Its just list of links used in the doc, and jaeger was duplicated (and so removed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some other minor local changes also got bundled, hope they are okay!