Add basic doc comments for opentelemetry-http #1528
Conversation
| @@ -7,6 +7,10 @@ pub use bytes::Bytes; | |||
| pub use http::{Request, Response}; | |||
| use opentelemetry::propagation::{Extractor, Injector}; | |||
|
|
|||
| /// Helper for injecting headers into HTTP Requests. This is used for OpenTelemetry context | |||
There was a problem hiding this comment.
From a quick glance, this can be moved out to its own crate, as this does not require any particular httpclient implementation, so can move quickly.
Would it help anyone if we move this to own crate? I guess there are users who need this part (for context propagation over http), but does not need an exporting mechanism over http (as they can use alternatives like gRPC)?
There was a problem hiding this comment.
@TommyCpp suggested its better to keep crate count low, but we can achieve this via feature flags.. Will have to follow up separately for that.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1528 +/- ##
=====================================
Coverage 61.8% 61.9%
=====================================
Files 144 144
Lines 19810 19862 +52
=====================================
+ Hits 12256 12303 +47
- Misses 7554 7559 +5 ☔ View full report in Codecov by Sentry. |
Basic doc comments, as it was never clear what was the purpose of opentelemetry-http crate.
Related issue #1427 (This PR is in no way fixing that issue!)