Remove support for surf HTTP client #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1537 +/- ##
=======================================
+ Coverage 65.5% 65.8% +0.2%
=======================================
Files 140 140
Lines 19569 19488 -81
=======================================
Hits 12824 12824
+ Misses 6745 6664 -81 ☔ View full report in Codecov by Sentry. |
hdost
reviewed
Feb 16, 2024
shaun-cox
approved these changes
Feb 16, 2024
|
Also towards #1427 (comment) |
cijothomas
approved these changes
Feb 16, 2024
|
Good to merge once merge conflicts resolved, and the changelog calls out breaking change! Thanks @djc |
djc
force-pushed
the
no-surf
branch
2 times, most recently
from
e752d7d
to
c519c11
Compare
|
Rebased. How do you all feel about pushing out a release once this is merged? IMO it would be quite helpful to get the bumped tonic/prost dependencies out there given that they were severely lagging at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In a similar vein as #1534 / #1524, surf has seen its last release over 2 years ago and by the admission of its maintainer is pretty much unmaintained. On crates.io, it got 166k downloads in the last three months, vs reqwest's 11.7M.
#1534
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes