Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown link CI check #1540

Merged
merged 13 commits into from
Feb 17, 2024
Merged

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Feb 16, 2024

Changes

Shamelessly copied from https://github.com/open-telemetry/opentelemetry-specification/blob/5d9cef817415a15aaa4883e184a38adec79096ed/.github/workflows/checks.yaml#L36, and fixed broken links.

This will recursively check all the markdown files (ignoring CHANGELOG.md), and fail if any dead link is found.

If a CI check isn't necessary, I can modify the PR to exclude it, focusing solely on the updates to the broken links.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner February 16, 2024 19:20
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59f5371) 65.8% compared to head (841a123) 65.8%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1540   +/-   ##
=====================================
  Coverage   65.8%   65.8%           
=====================================
  Files        140     140           
  Lines      19505   19505           
=====================================
  Hits       12841   12841           
  Misses      6664    6664           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 1be83bb into open-telemetry:main Feb 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants