-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markdown link CI check #1540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1540 +/- ##
=====================================
Coverage 65.8% 65.8%
=====================================
Files 140 140
Lines 19505 19505
=====================================
Hits 12841 12841
Misses 6664 6664 ☔ View full report in Codecov by Sentry. |
lalitb
commented
Feb 16, 2024
cijothomas
reviewed
Feb 16, 2024
cijothomas
reviewed
Feb 16, 2024
cijothomas
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Shamelessly copied from https://github.com/open-telemetry/opentelemetry-specification/blob/5d9cef817415a15aaa4883e184a38adec79096ed/.github/workflows/checks.yaml#L36, and fixed broken links.
This will recursively check all the markdown files (ignoring CHANGELOG.md), and fail if any dead link is found.
If a CI check isn't necessary, I can modify the PR to exclude it, focusing solely on the updates to the broken links.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes