Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix span kind being always internal #1576

Merged

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Feb 26, 2024

Fixes #1575
Also adds slightly better test coverage. The whole testing needs to be revisited to ensure we have sufficient coverage, this PR is just adding the minimal test addition only.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team as a code owner February 26, 2024 01:48
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.3%. Comparing base (ab9415a) to head (c26a807).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1576     +/-   ##
=======================================
+ Coverage   66.8%   67.3%   +0.4%     
=======================================
  Files        138     138             
  Lines      19290   19346     +56     
=======================================
+ Hits       12903   13029    +126     
+ Misses      6387    6317     -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas closed this Feb 26, 2024
@cijothomas cijothomas reopened this Feb 26, 2024
@cijothomas cijothomas merged commit 5542f37 into open-telemetry:main Feb 26, 2024
25 of 27 checks passed
@cijothomas
Copy link
Member Author

Going to do a .1 release shortly with this change.

@cijothomas cijothomas deleted the cijothomas/span-kind-bug-fix branch February 26, 2024 17:33
@cijothomas
Copy link
Member Author

Going to do a .1 release shortly with this change.

@hdost @TommyCpp
I'll attempt to do this, also to validate that I have permissions to push to crates.io!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Span kind is always set to "internal" in v0.22.0
2 participants