Modify main readme and contrib guide #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1581 +/- ##
=======================================
- Coverage 67.3% 67.3% -0.1%
=======================================
Files 138 138
Lines 19346 19346
=======================================
- Hits 13030 13029 -1
- Misses 6316 6317 +1 ☔ View full report in Codecov by Sentry. |
lalitb
reviewed
Feb 27, 2024
lalitb
approved these changes
Feb 27, 2024
hdost
approved these changes
Feb 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of changes are done to make it more consistent with other languages in OTel.
Also cleaned up main readme to remove the ecosystem part, and lists the components from this repo directlyn and recommends using registry/contrib repo for other crates.
The getting started part is only for tracing, I expect to enhance that in a subsequent PR. (That code also has a bug, as it never sets anything to global provider, but still calls shutdown on global.. Fixes coming up next)