Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: URLs in OTLP exporters #1706

Merged
merged 11 commits into from
May 8, 2024
Merged

fix: URLs in OTLP exporters #1706

merged 11 commits into from
May 8, 2024

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented May 6, 2024

Fixes #1618
Design discussion issue (if applicable) #

Changes

  • Clearify the documentation that the endpoint in ExporterConfig should be complete. i.e exporter will not append signal path onto it.

  • Removed the signal path for default grpc endpoints. As in grpc protocol, path is decided by the package name. Users can still add path if they manually config it

Path is case-sensitive. Some gRPC implementations may allow the Path format shown above to be overridden, but this functionality is strongly discouraged. gRPC does not go out of its way to break users that are using this kind of override, but we do not actively support it, and some functionality (e.g., service config support) will not work when the path is not of the form shown above.

  • Don't append anything if the users add a path in ExportConfig. URLs from env vars don't append anything so we should keep them consistent

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@TommyCpp
Copy link
Contributor Author

TommyCpp commented May 6, 2024

block on #1704 for the new version fix

@TommyCpp TommyCpp added the integration tests Run integration tests label May 6, 2024
@TommyCpp TommyCpp marked this pull request as ready for review May 6, 2024 23:55
@TommyCpp TommyCpp requested a review from a team as a code owner May 6, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: opentelemetry-otlp inconsistency between http and grpc export endpoint for traces
3 participants