-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: clean up trace SDK APIs #1755
feat: clean up trace SDK APIs #1755
Conversation
2b94e6c
to
13bde88
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1755 +/- ##
=====================================
Coverage 74.4% 74.4%
=====================================
Files 122 122
Lines 19807 19800 -7
=====================================
Hits 14750 14750
+ Misses 5057 5050 -7 ☔ View full report in Codecov by Sentry. |
I think this update to opentelemetry-proto submodule is not intended, as we are already using the latest version :) |
2d64b24
to
683ec99
Compare
opentelemetry-sdk/CHANGELOG.md
Outdated
@@ -61,13 +65,7 @@ | |||
- After `shutdown`, `LogProcessor` will not process any new logs | |||
- Moving LogRecord implementation to the SDK. [1702](https://github.com/open-telemetry/opentelemetry-rust/pull/1702). | |||
- Relocated `LogRecord` struct to SDK, as an implementation for the trait in the API. | |||
- **Breaking** [#1729](https://github.com/open-telemetry/opentelemetry-rust/pull/1729) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we cannot remove this as it is already part of shipped code!
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes