Add more observable counter tests #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1818 +/- ##
=======================================
- Coverage 73.6% 73.6% -0.1%
=======================================
Files 122 122
Lines 19529 19515 -14
=======================================
- Hits 14389 14376 -13
+ Misses 5140 5139 -1 ☔ View full report in Codecov by Sentry. |
lalitb
reviewed
May 24, 2024
lalitb
reviewed
May 24, 2024
| // Run this test with stdout enabled to see output. | ||
| // cargo test observable_counter_aggregation --features=metrics,testing -- --nocapture | ||
| // cargo test observable_counter_aggregation_cumulative_non_zero_increment --features=testing -- --nocapture |
There was a problem hiding this comment.
nit - I know this is the existing comment. Do we know what output tester may want to see with nocapture as mentioned in this comment. Not blocker, just curious.
There was a problem hiding this comment.
println() text is not captured in test output without this. It is used when debugging things quickly. Sometimes it is a lot easier that way, as opposed to running with RUST_FLAG to show stack when tests panic!
lalitb
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrating #1517
This adds more scenarios to improve coverage overall.
#1644 has the fix, but that is not yet merged as we are working through some major refactoring!