Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SetResource return status, and call it synchronously in Batch[Log|Span]Processor #1898

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Merge branch 'main' into set-resource-status

0608390
Select commit
Loading
Failed to load commit list.
Open

Make SetResource return status, and call it synchronously in Batch[Log|Span]Processor #1898

Merge branch 'main' into set-resource-status
0608390
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 29, 2024 in 0s

74.8% (-0.2%) compared to cd59346

View this Pull Request on Codecov

74.8% (-0.2%) compared to cd59346

Details

Codecov Report

Attention: Patch coverage is 60.00000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 74.8%. Comparing base (cd59346) to head (0608390).

Files Patch % Lines
opentelemetry-sdk/src/logs/log_processor.rs 72.4% 8 Missing ⚠️
opentelemetry-sdk/src/trace/span_processor.rs 65.2% 8 Missing ⚠️
opentelemetry-otlp/src/logs.rs 0.0% 5 Missing ⚠️
opentelemetry-sdk/src/export/logs/mod.rs 0.0% 3 Missing ⚠️
opentelemetry-otlp/src/exporter/http/logs.rs 0.0% 2 Missing ⚠️
opentelemetry-otlp/src/exporter/http/trace.rs 0.0% 2 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/logs.rs 0.0% 2 Missing ⚠️
opentelemetry-stdout/src/logs/exporter.rs 0.0% 2 Missing ⚠️
opentelemetry-stdout/src/trace/exporter.rs 0.0% 2 Missing ⚠️
opentelemetry-sdk/src/logs/log_emitter.rs 66.6% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #1898     +/-   ##
=======================================
- Coverage   74.9%   74.8%   -0.2%     
=======================================
  Files        122     122             
  Lines      20404   20441     +37     
=======================================
+ Hits       15289   15296      +7     
- Misses      5115    5145     +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov