Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Baggage] Simplify Get APIs #1902

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jun 28, 2024

Changes

  • We can loosen the restrictions on the type of key required for get baggage APIs to any type that is guaranteed to return a &str
  • Currently, we require the type to be Into<Key> which not only requires the user to know which types can be converted into Key but also, we don't support conversions into Key for a lot of types such as Rc<String>, RefCell<String> etc.

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team as a code owner June 28, 2024 17:25
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.0%. Comparing base (d5c86d9) to head (a30ef98).

Files Patch % Lines
opentelemetry/src/baggage.rs 50.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1902     +/-   ##
=======================================
- Coverage   75.0%   75.0%   -0.1%     
=======================================
  Files        122     122             
  Lines      20279   20285      +6     
=======================================
+ Hits       15211   15215      +4     
- Misses      5068    5070      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb merged commit ad990d6 into open-telemetry:main Jul 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants