Predefine Vector Capacity for LogRecord Attributes #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1908 +/- ##
=====================================
Coverage 75.0% 75.0%
=====================================
Files 122 122
Lines 20285 20289 +4
=====================================
+ Hits 15218 15221 +3
- Misses 5067 5068 +1 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
Jul 3, 2024
| @@ -10,7 +10,7 @@ | |||
| | noop_layer_disabled | 12 ns | | |||
| | noop_layer_enabled | 25 ns | | |||
| | ot_layer_disabled | 19 ns | | |||
| | ot_layer_enabled | 371 ns | | |||
| | ot_layer_enabled | 270 ns | | |||
There was a problem hiding this comment.
❤️ this! Could you update stress tests too?
There was a problem hiding this comment.
updated stress. The benchmark shows improvement from 391 ns -> 305 ns. Updated that too.
cijothomas
reviewed
Jul 3, 2024
cijothomas
approved these changes
Jul 3, 2024
utpilla
reviewed
Jul 3, 2024
utpilla
approved these changes
Jul 3, 2024
ThomsonTan
reviewed
Jul 3, 2024
ThomsonTan
reviewed
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1896
Stress test
Before:
Throughput: 57,703,000 iterations/sec
Memory usage: 3.70 MB
CPU usage: 99.87512%
Virtual memory usage: 2249.05 MB
With PR:
Throughput: 70,031,600 iterations/sec
Memory usage: 3.98 MB
CPU usage: 100%
Virtual memory usage: 2249.05 MB
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes