Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentelemetry: replace regex with custom validation logic #411

Merged
merged 1 commit into from
Jan 4, 2021
Merged

opentelemetry: replace regex with custom validation logic #411

merged 1 commit into from
Jan 4, 2021

Conversation

djc
Copy link
Contributor

@djc djc commented Jan 4, 2021 •
edited
Loading

See #403.

@djc djc requested a review from a team as a code owner January 4, 2021 09:03
@codecov
Copy link

codecov bot commented Jan 4, 2021 •
edited
Loading

Codecov Report

Merging #411 (ceb07a3) into master (3dcae6b) will decrease coverage by 0.01%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
- Coverage   49.45%   49.43%   -0.02%     
==========================================
  Files          66       66              
  Lines        5421     5435      +14     
==========================================
+ Hits         2681     2687       +6     
- Misses       2740     2748       +8
Impacted Files Coverage Δ
opentelemetry/src/api/trace/span_context.rs 71.67% <46.66%> (-1.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dcae6b...ceb07a3. Read the comment docs.

@djc djc mentioned this pull request Jan 4, 2021
Closed
jtescher
jtescher approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djc

@djc
opentelemetry: replace regex with custom validation logic
ceb07a3 
Also update the logic to match the current specification.
@jtescher jtescher merged commit 5af183f into open-telemetry:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtescher jtescher jtescher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djc @jtescher