Create BatchSpanProcessor from env in TracerProvider #445
Conversation
| crate::util::tokio_interval_stream, | ||
| tokio::time::sleep, |
There was a problem hiding this comment.
Oddly, from_env switches these two last arguments :(
There was a problem hiding this comment.
yeah that looks like an oversight, want to create a PR to fix that?
This allows for configuring BSP when just `with_exporter` is used, instead of requiring users to create the BSP themselves when they want to pull from the environment.
samschlegel
force-pushed
the
tracerprovider-create-bsp-from-env
branch
from
aee7248
to
0ff3ed5
Compare
Codecov Report
@@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 48.80% 48.78% -0.02%
==========================================
Files 66 66
Lines 5450 5450
==========================================
- Hits 2660 2659 -1
- Misses 2790 2791 +1
Continue to review full report at Codecov.
|
| crate::util::tokio_interval_stream, | ||
| tokio::time::sleep, |
There was a problem hiding this comment.
yeah that looks like an oversight, want to create a PR to fix that?
|
We discussed the |
This allows for configuring BSP when just
with_exporteris used, instead of requiring users to create the BSP themselves when they want to pull from the environment.It's possible that maybe this isn't the best route to go, and should instead just have users of TracerProvider expose with_batch_exporter themselves and have people pass
with_envup, but figured I'd throw this together as it was the simplest thing to get what we needed and start the conversation 😄