Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename get_tracer to tracer #586

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Rename get_tracer to tracer #586

merged 1 commit into from
Jun 25, 2021

Conversation

jtescher
Copy link
Member

Rename tracer provider methods as it is less idiomatic for rust methods to have the get prefix.

@jtescher jtescher requested a review from a team as a code owner June 25, 2021 20:33
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #586 (05760e1) into main (068aacc) will not change coverage.
The diff coverage is 72.2%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #586   +/-   ##
=====================================
  Coverage   54.7%   54.7%           
=====================================
  Files        102     102           
  Lines       8846    8846           
=====================================
  Hits        4842    4842           
  Misses      4004    4004           
Impacted Files Coverage Δ
opentelemetry-datadog/src/exporter/mod.rs 12.2% <0.0%> (ø)
opentelemetry-jaeger/src/exporter/mod.rs 47.7% <0.0%> (ø)
opentelemetry-zipkin/src/exporter/mod.rs 0.0% <0.0%> (ø)
opentelemetry/src/sdk/export/trace/stdout.rs 9.6% <ø> (ø)
opentelemetry/src/sdk/propagation/composite.rs 95.6% <ø> (ø)
opentelemetry/src/trace/context.rs 37.1% <ø> (ø)
opentelemetry/src/trace/mod.rs 50.0% <ø> (ø)
opentelemetry/src/global/trace.rs 17.0% <71.4%> (ø)
opentelemetry/src/sdk/trace/provider.rs 81.8% <100.0%> (ø)
opentelemetry/src/sdk/trace/span.rs 95.0% <100.0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 068aacc...05760e1. Read the comment docs.

@jtescher jtescher merged commit b58d095 into main Jun 25, 2021
@jtescher jtescher deleted the rename-get-tracer branch June 25, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants