Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: try split batch if payload size larger than max_package_size #619

Merged
merged 7 commits into from
Aug 23, 2021
Merged

Conversation

DCjanus
Copy link
Contributor

@DCjanus DCjanus commented Aug 18, 2021

Close: #545

@DCjanus DCjanus requested a review from a team as a code owner August 18, 2021 14:21
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 18, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #619 (615d7f5) into main (df01fb3) will decrease coverage by 0.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
- Coverage   62.52%   62.08%   -0.44%     
==========================================
  Files          95       95              
  Lines        7648     7681      +33     
==========================================
- Hits         4782     4769      -13     
- Misses       2866     2912      +46     
Impacted Files Coverage Δ
opentelemetry-jaeger/src/exporter/agent.rs 0.00% <0.00%> (ø)
opentelemetry-jaeger/src/exporter/mod.rs 46.66% <0.00%> (-1.02%) ⬇️
opentelemetry/src/metrics/noop.rs 41.50% <0.00%> (-3.32%) ⬇️
opentelemetry/src/trace/noop.rs 76.00% <0.00%> (-0.70%) ⬇️
opentelemetry/src/sdk/trace/evicted_hash_map.rs 66.29% <0.00%> (-0.38%) ⬇️
opentelemetry/src/sdk/resource/env.rs 86.20% <0.00%> (-0.24%) ⬇️
opentelemetry/src/context.rs 92.85% <0.00%> (-0.06%) ⬇️
opentelemetry-jaeger/src/lib.rs 92.14% <0.00%> (-0.05%) ⬇️
opentelemetry/src/sdk/propagation/baggage.rs 96.40% <0.00%> (-0.03%) ⬇️
opentelemetry/src/sdk/propagation/trace_context.rs 97.22% <0.00%> (-0.02%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df01fb3...615d7f5. Read the comment docs.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks like a good solution. Thanks a lot. Could you add some unit tests around it?

opentelemetry-jaeger/src/exporter/agent.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awesome work 🎉

@TommyCpp TommyCpp merged commit a0899d9 into open-telemetry:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow option to split oversiezd jaeger UDP batches
2 participants