-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: try split batch if payload size larger than max_package_size #619
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #619 +/- ##
==========================================
- Coverage 62.52% 62.08% -0.44%
==========================================
Files 95 95
Lines 7648 7681 +33
==========================================
- Hits 4782 4769 -13
- Misses 2866 2912 +46
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks like a good solution. Thanks a lot. Could you add some unit tests around it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Awesome work 🎉
Close: #545