fix: detect service.name from OTEL_SERVICE_NAME and OTEL_RESOURCE_ATTRIBUTES #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RIBUTES. OTEL_SERVICE_NAME will take priority and if it's not available. We will try to detect the service.name from OTEL_RESOURCE_ATTRIBUTES. If it's also not available. We will use the default one.
Codecov Report
@@ Coverage Diff @@
## main #662 +/- ##
==========================================
+ Coverage 62.13% 62.22% +0.09%
==========================================
Files 95 95
Lines 7719 7738 +19
==========================================
+ Hits 4796 4815 +19
Misses 2923 2923
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTEL_SERVICE_NAME will take priority and if it's not available. We will try to detect the service.name from OTEL_RESOURCE_ATTRIBUTES. If it's also not available. We will use the default one.