Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update dashmap to avoid soundness hole #818

Merged
merged 1 commit into from
Jun 27, 2022
Merged

fix: update dashmap to avoid soundness hole #818

merged 1 commit into from
Jun 27, 2022

Conversation

Daniel-Bloom-dfinity
Copy link
Contributor

xacrimon/dashmap#167 has a soundness hole pre 5.1.0.

@Daniel-Bloom-dfinity Daniel-Bloom-dfinity requested a review from a team as a code owner June 20, 2022 16:37
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 20, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Daniel-Bloom-dfinity / name: Daniel Bloom (ffa55ad)

@codecov
Copy link

codecov bot commented Jun 20, 2022 •
edited

Codecov Report

Merging #818 (ffa55ad) into main (2585d10) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main    #818     +/-   ##
=======================================
- Coverage   69.8%   69.8%   -0.1%     
=======================================
  Files        110     110             
  Lines       9072    9072             
=======================================
- Hits        6334    6333      -1     
- Misses      2738    2739      +1
Impacted Files Coverage Δ
opentelemetry-sdk/src/metrics/controllers/push.rs 80.0% <0.0%> (-3.4%) ⬇️
opentelemetry-sdk/src/runtime.rs 69.7% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2585d10...ffa55ad. Read the comment docs.

TommyCpp
TommyCpp approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for catching this. Just need sign the CLA

@Daniel-Bloom-dfinity
Copy link
Contributor Author

Signed.

@jtescher jtescher merged commit b5c3ec6 into open-telemetry:main Jun 27, 2022
This was referenced Jul 24, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TommyCpp TommyCpp TommyCpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Daniel-Bloom-dfinity @TommyCpp @jtescher