Skip to content

Commit

Permalink
add name suggestion to prometheus exporter option (#3837)
Browse files Browse the repository at this point in the history
## Changes

Similarly to the other options listed in the Prometheus exporter
specification, adding a suggested name for the option to apply resource
attributes as metric attributes.
  • Loading branch information
codeboten committed Apr 19, 2024
1 parent 100045e commit 2bbcd2d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Expand Up @@ -13,6 +13,9 @@ release.

### Metrics

- Add name suggestion for option to apply resource attributes as metric attributes in Prometheus exporter.
([#3837](https://github.com/open-telemetry/opentelemetry-specification/pull/3837))

### Logs

### Events
Expand Down
2 changes: 1 addition & 1 deletion specification/metrics/sdk_exporters/prometheus.md
Expand Up @@ -44,7 +44,7 @@ A Prometheus Exporter MAY offer configuration to add resource attributes as metr
By default, it MUST NOT add any resource attributes as metric attributes.
The configuration SHOULD allow the user to select which resource attributes to copy (e.g.
include / exclude or regular expression based). Copied Resource attributes MUST NOT be
excluded from the `target` info metric.
excluded from the `target` info metric. The option MAY be named `with_resource_constant_labels`.

A Prometheus Exporter MAY support a configuration option to produce metrics without a [unit suffix](../../compatibility/prometheus_and_openmetrics.md#metric-metadata)
or UNIT metadata. The option MAY be named `without_units`, and MUST be `false` by default.
Expand Down

0 comments on commit 2bbcd2d

Please sign in to comment.