Skip to content

Commit

Permalink
added section for browsers, clarified device as client-side only
Browse files Browse the repository at this point in the history
  • Loading branch information
Martin Kuba committed Nov 10, 2021
1 parent 480a19d commit 353a872
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 3 deletions.
4 changes: 2 additions & 2 deletions specification/resource/semantic_conventions/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ This document defines standard attributes for resources. These attributes are ty
## TODOs

* Add more compute units: AppEngine unit, etc.
* Add Web Browser.
* Decide if lower case strings only.
* Consider to add optional/required for each attribute and combination of attributes
(e.g when supplying a k8s resource all k8s may be required).
Expand Down Expand Up @@ -151,11 +150,12 @@ Attributes defining a computing instance (e.g. host):
Attributes defining a running environment (e.g. Operating System, Cloud, Data Center, Deployment Service):

- [Operating System](./os.md)
- [Device](./device.md)
- [Device](./device.md) (client-side)
- [Cloud](./cloud.md)
- Deployment:
- [Deployment Environment](./deployment_environment.md)
- [Kubernetes](./k8s.md)
- [Browser](./browser.md)

## Version attributes

Expand Down
15 changes: 15 additions & 0 deletions specification/resource/semantic_conventions/browser.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Browser

**Status**: [Experimental](../../document-status.md)

**type:** `browser`

**Description**: The web browser in which the application represented by the resource is running. The `browser.*` attributes MUST be used only for resources that represent client-side devices - the presence of these attributes can be used to identify client-side telemetry.

<!-- semconv device -->
| Attribute | Type | Description | Examples | Required |
|---|---|---|---|---|
| `browser.name` | string | The web browser name | `Chrome` | No |
| `browser.version` | string | The web browser version | `90` | No |
| `browser.platform` | string | The operating system | `Windows` | No |
| `browser.mobile` | boolean | Flag indicating a mobile device | | No |
2 changes: 1 addition & 1 deletion specification/resource/semantic_conventions/device.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

**type:** `device`

**Description**: The device on which the process represented by this resource is running.
**Description**: The device on which the process represented by this resource is running. The `device.*` attributes MUST be used only for resources that represent client-side devices - the presence of these attributes can be used to identify client-side telemetry.

<!-- semconv device -->
| Attribute | Type | Description | Examples | Required |
Expand Down

0 comments on commit 353a872

Please sign in to comment.