Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define metric semantic conventions for FaaS #1013

Closed
jgals opened this issue Sep 25, 2020 · 6 comments · Fixed by #1736
Closed

Define metric semantic conventions for FaaS #1013

jgals opened this issue Sep 25, 2020 · 6 comments · Fixed by #1736
Assignees
@kolanos
Labels
area:semantic-conventions Related to semantic conventions priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory
Projects
GA Spec Burndown

Comments

@jgals
Copy link

jgals commented Sep 25, 2020

What are you trying to achieve?
Defined semantic conventions for function as a service (FaaS) metrics, often referred to as "serverless" metrics.

What did you expect to see?
FaaS metric semantic convention documentation in markdown generated from YAML definitions as per #547.

Additional context.
These should be roughly analogous to the trace semantic conventions for FaaS spans defined here. For reference, metric semantic conventions for HTTP operations are already defined here.
@jgals jgals added the spec:metrics Related to the specification/metrics directory label Sep 25, 2020
@arminru arminru added the area:semantic-conventions Related to semantic conventions label Sep 25, 2020
@andrewhsu andrewhsu added priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Oct 2, 2020
@jgals
Copy link
Author

jgals commented Oct 2, 2020

Hey @jmacd, can we add @kolanos to the project so he can be assigned to this issue? I believe he's working on a PR.

@Oberon00
Copy link
Member

Oberon00 commented Oct 2, 2020

@kolanos just needs to comment on this issue, then he can be assigned.

@kolanos
Copy link
Contributor

kolanos commented Oct 5, 2020

@Oberon00 Commented. :)

kolanos added a commit to kolanos/opentelemetry-specification that referenced this issue Oct 5, 2020
@kolanos
Define FaaS Metric Semantics
05c5c09 
Closes open-telemetry#1013
@kolanos kolanos mentioned this issue Oct 5, 2020
Closed
kolanos added a commit to kolanos/opentelemetry-specification that referenced this issue Oct 5, 2020
@kolanos
Define FaaS Metric Semantics
a0bda83 
Closes open-telemetry#1013
@Oberon00 Oberon00 assigned kolanos and unassigned jgals Oct 5, 2020
kolanos added a commit to kolanos/opentelemetry-specification that referenced this issue Oct 5, 2020
@kolanos
Define FaaS Metric Semantics
ba19150 
Closes open-telemetry#1013
@andrewhsu andrewhsu added this to Required for GA, needs action. Add label:release:required-for-ga to issues and PRs when moving them to this column. in GA Spec Burndown Oct 6, 2020
@andrewhsu andrewhsu moved this from Required for GA, needs action. Add label:release:required-for-ga to issues and PRs when moving them to this column. to Required for GA, in progress in GA Spec Burndown Oct 6, 2020
kolanos added a commit to kolanos/opentelemetry-specification that referenced this issue Oct 15, 2020
@kolanos
Define FaaS Metric Semantics
960c883 
Closes open-telemetry#1013
kolanos added a commit to kolanos/opentelemetry-specification that referenced this issue Oct 15, 2020
@kolanos
Define FaaS Metric Semantics
407c778 
Closes open-telemetry#1013
@andrewhsu andrewhsu added priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs and removed priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Oct 16, 2020
kolanos added a commit to kolanos/opentelemetry-specification that referenced this issue Oct 22, 2020
@kolanos
Define FaaS Metric Semantics
855b9d6 
Closes open-telemetry#1013
kolanos added a commit to kolanos/opentelemetry-specification that referenced this issue Oct 30, 2020
@kolanos
Define FaaS Metric Semantics
4c4d317 
Closes open-telemetry#1013
kolanos added a commit to kolanos/opentelemetry-specification that referenced this issue Nov 4, 2020
@kolanos
Define FaaS Metric Semantics
1217ca5 
Closes open-telemetry#1013
kolanos added a commit to kolanos/opentelemetry-specification that referenced this issue Nov 5, 2020
@kolanos
Define FaaS Metric Semantics
0bd0ef3 
Closes open-telemetry#1013
@skonto
Copy link
Contributor

skonto commented May 20, 2021 •
edited
Loading

Hi @kolanos are you still involved in this issue? I am interested in defining the related faas metrics as I am working on defining these for Knative.

@skonto
Copy link
Contributor

skonto commented May 26, 2021 •
edited
Loading

Hi @jmacd is there a way to push forward this? I think @kolanos has something as wip but if there are no cycles I can pick it up.

@kolanos
Copy link
Contributor

kolanos commented May 27, 2021

@skonto If you want to pick up where I left off, I'm +1. Happy to provide feedback as well.

skonto pushed a commit to skonto/opentelemetry-specification that referenced this issue May 31, 2021
@kolanos @skonto
Define FaaS Metric Semantics
2be5b10 
Closes open-telemetry#1013
@skonto skonto mentioned this issue May 31, 2021
Merged
skonto pushed a commit to skonto/opentelemetry-specification that referenced this issue Jun 9, 2021
@kolanos @skonto
Define FaaS Metric Semantics
59f6472 
Closes open-telemetry#1013
skonto pushed a commit to skonto/opentelemetry-specification that referenced this issue Jul 12, 2021
@kolanos @skonto
Define FaaS Metric Semantics
723d77b 
Closes open-telemetry#1013
GA Spec Burndown automation moved this from Required/Allowed for GA, with linked PR. to Required/Allowed for GA, resolved. Aug 10, 2021
jmacd pushed a commit that referenced this issue Aug 10, 2021
@skonto @kolanos @carlosalberto
Add FaaS metrics semantic conventions (#1736)
1433e3f 
* Define FaaS Metric Semantics

Closes #1013

* adjust faas metrics

* fixes

* docs

* updates

* fixes

* update instruments

* use attributes

Co-authored-by: Michael Lavers <kolanos@gmail.com>
Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kolanos kolanos

Labels
area:semantic-conventions Related to semantic conventions priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory
Projects
No open projects
GA Spec Burndown
  
Required/Allowed for GA, resolved.
Milestone
No milestone
6 participants
@kolanos @andrewhsu @Oberon00 @arminru @skonto @jgals