Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define metric semantic conventions for messaging systems #1014

Closed
jgals opened this issue Sep 25, 2020 · 3 comments · Fixed by open-telemetry/semantic-conventions#163
Closed

Define metric semantic conventions for messaging systems #1014

jgals opened this issue Sep 25, 2020 · 3 comments · Fixed by open-telemetry/semantic-conventions#163
Assignees
@lmolkova
Labels
area:semantic-conventions Related to semantic conventions priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory
Projects
GA Spec Burndown

Comments

@jgals
Copy link

jgals commented Sep 25, 2020

What are you trying to achieve?
Documented metric semantic conventions for various messaging systems.

What did you expect to see?
Metric semantic conventions for messaging documented in markdown generated from YAML definitions as per #547.

Additional context.
These should be roughly analogous to the trace semantic conventions for messaging defined here. For reference, metric semantic conventions for HTTP operations are already defined here.
@jgals jgals added the spec:metrics Related to the specification/metrics directory label Sep 25, 2020
@arminru arminru added the area:semantic-conventions Related to semantic conventions label Sep 25, 2020
@cwildman
Copy link

cwildman commented Oct 1, 2020

I'll take this PR

@andrewhsu andrewhsu added priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Oct 2, 2020
@andrewhsu andrewhsu added this to Required for GA, needs action. Add label:release:required-for-ga to issues and PRs when moving them to this column. in GA Spec Burndown Oct 6, 2020
@cwildman cwildman mentioned this issue Oct 8, 2020
Closed
@andrewhsu andrewhsu added priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs and removed priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Oct 16, 2020
@andrewhsu andrewhsu moved this from Required/Allowed for GA, todo. to Required/Allowed for GA, with linked PR. in GA Spec Burndown Oct 23, 2020
@andrewhsu
Copy link
Member

@jgals or @cwildman does PR #1077 resolve this issue? if so, can you link the PR to this issue?

cwildman added a commit to cwildman/opentelemetry-specification that referenced this issue Oct 23, 2020
@cwildman
Initial semantic conventions for messaging metrics. open-telemetry#1014
b98cb81
cwildman added a commit to cwildman/opentelemetry-specification that referenced this issue Oct 23, 2020
@cwildman
Initial semantic conventions for messaging metrics. open-telemetry#1014
c91a9b5
@cwildman
Copy link

Yes #1077 resolves this issue, I linked them now.

cwildman added a commit to cwildman/opentelemetry-specification that referenced this issue Nov 10, 2020
@cwildman
Initial semantic conventions for messaging metrics. open-telemetry#1014
828c7d5
@pyohannes pyohannes assigned lmolkova and unassigned cwildman Mar 23, 2023
@pyohannes pyohannes linked a pull request Jul 27, 2023 that will close this issue
Define messaging metrics and add error.type attribute to spans open-telemetry/semantic-conventions#163
Merged
@lmolkova lmolkova mentioned this issue Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmolkova lmolkova

Labels
area:semantic-conventions Related to semantic conventions priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory
Projects
Spec: Messaging Semantics
Status: V1 - Stable Semantics
GA Spec Burndown
  
Required/Allowed for GA, with linked PR.
Milestone
No milestone
5 participants
@andrewhsu @cwildman @lmolkova @arminru @jgals