Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "best Histogram Aggregation available" option #2382

Closed
jack-berg opened this issue Feb 25, 2022 · 0 comments · Fixed by #2429
Closed

Remove "best Histogram Aggregation available" option #2382

jack-berg opened this issue Feb 25, 2022 · 0 comments · Fixed by #2429
Assignees
Labels
spec:metrics Related to the specification/metrics directory

Comments

@jack-berg
Copy link
Member

The SDK histogram aggregation "informs the SDK to select the best Histogram Aggregation available". (Here's a conversation discussing the original inclusion of this language.)

If I understand correctly, this would reserve SDKs the right to change their definition of the "best histogram aggregation available" from one release to the next. For example, an SDK might choose to change the default bucket boundaries for the explicit bucket histogram, or an SDK might change from explicit bucket histogram to exponential histogram.

We discussed this in the Java SIG and believe that allowing for this type of change in behavior is unacceptable from a user experience standpoint. Changing either the bucket boundaries, or from explicit bucket to exponential histogram would change and potentially break backend behavior.

Instead, the "histogram" aggregation should have a consistent, reliable definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
2 participants