Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details for Aggregator in Metrics Spec. #1842

Merged
merged 17 commits into from Aug 19, 2021

Conversation

victlu
Copy link
Contributor

@victlu victlu commented Aug 2, 2021

Add more details for an Aggregator in the Metrics Spec.

This PR is a rework of #1804 after discussions and feedback from metric SIG meetings.

Copy link
Member

@pirgeo pirgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagged a few typos, but overall I think it is very clear and concise 👍

specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Show resolved Hide resolved
@jsuereth
Copy link
Contributor

Want to confirm a few points that I think are implicit in this PR that perhaps deserve some in person discussion:

  1. Default aggregation for synchronous instruments is DELTA right now, not cumulative.
  2. This PR does not define any kind of "back-hook" where exports can ask for a specific type of temporal aggregation (delta vs. cumulative). The configuration of the View (or default) determines the temporarlity.
  3. The public names exposed in SDK to users are "GAUGE", "SUM" and "HISTOGRAM", vs. the more specific name used in the section.

specification/metrics/sdk.md Outdated Show resolved Hide resolved
@jmacd
Copy link
Contributor

jmacd commented Aug 12, 2021

Thank you @victlu. I know this has been a lot of work!

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jmacd
Copy link
Contributor

jmacd commented Aug 17, 2021

@cijothomas are you happy with the edits that @victlu has made? This looks ready to merge.

### Aggregation

An `Aggregation`, as configured via the [View](./sdk.md#view),
informs the SDK on the ways and means to compute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since we don't specify any "how" here, "ways and means" sounds too much.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left small editorial comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants