Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security in Prometheus exporter #2400

Open
fmhwong opened this issue Mar 3, 2022 · 4 comments
Open

Security in Prometheus exporter #2400

fmhwong opened this issue Mar 3, 2022 · 4 comments
Assignees
Labels
area:sdk Related to the SDK help wanted Extra attention is needed spec:metrics Related to the specification/metrics directory triage:deciding:community-feedback

Comments

@fmhwong
Copy link

fmhwong commented Mar 3, 2022

What are you trying to achieve?
In the current spec for the Prometheus exporter https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/prometheus.md, it doesn't mention anything about securing the metrics endpoint.

When using the automatic instrumentation opentelemetry-javaagent.jar and the Prometheus exporter is enabled, the metrics endpoint (e.g. http://localhost:9464/) is not protected.

What did you expect to see?
There should be an option to use https and have the metrics endpoint protected by

  • username/password
  • OpenShift service account token

Additional context.

Add any other context about the problem here. If you followed an existing documentation, please share the link to it.

@fmhwong fmhwong added the spec:metrics Related to the specification/metrics directory label Mar 3, 2022
@yurishkuro yurishkuro added the help wanted Extra attention is needed label Mar 3, 2022
@reyang reyang added area:sdk Related to the SDK release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Mar 11, 2022
@sandeepsharat
Copy link

sandeepsharat commented Aug 16, 2023

Under which version is this feature released?...

@dyladan
Copy link
Member

dyladan commented Aug 21, 2023

@sandeepsharat it is no released. This is a feature request

@mtwo mtwo added triage:deciding:community-feedback and removed release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Jul 9, 2024
@mtwo
Copy link
Member

mtwo commented Jul 9, 2024

Chiming in during triage - this seems very useful. Tagging @open-telemetry/wg-prometheus for their comments.

@dashpole
Copy link
Contributor

dashpole commented Jul 9, 2024

This is a good idea, but might only apply to auto-instrumentation. From looking at manual instrumentation in a few languages, it looks like most allow you to either replace the HTTP handler, serve the endpoint using the prometheus client library, or require you to serve the http endpoint yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK help wanted Extra attention is needed spec:metrics Related to the specification/metrics directory triage:deciding:community-feedback
Projects
None yet
Development

No branches or pull requests

7 participants