Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify what information about child count Span data should carry #355

Open
tigrannajaryan opened this issue Nov 15, 2019 · 1 comment
Open

Clarify what information about child count Span data should carry #355

tigrannajaryan opened this issue Nov 15, 2019 · 1 comment
Labels
area:api Cross language API specification issue release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Nov 15, 2019 •
edited
Loading

Discussions around PRs open-telemetry/opentelemetry-proto#49 and open-telemetry/oteps#59 (comment) revealed that there is no clear understanding about what information about child count Span data should carry.

OpenCensus span data contained an optional child_span_count field and claims that If set, allows an implementation to detect missing child spans.

It is not clear whether we need to store number of local child count or number of global child count (and if yes how one is supposed to calculate or obtain this number).
@tigrannajaryan tigrannajaryan mentioned this issue Nov 15, 2019
Closed
@Oberon00
Copy link
Member

Better link to the discussion at the OTEP (GitHub seems to have problem with the one in the description, it seems to only work if you manually expand the resolved conversation in question manually beforehand): open-telemetry/oteps#59 (comment)

@fbogsany fbogsany mentioned this issue Nov 15, 2019
Closed
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-proto that referenced this issue Nov 25, 2019
Refine child span count field
ed81bc8 
The field was previously defined ambiguously and it was not clear
whether it was the count of local or all children (including remotely
generated).

This change makes it clear that this is only local children. A counter
of remote children may be added in the future if there is an understanding
about how to obtain this number (open discussion is here:
open-telemetry/opentelemetry-specification#355).

The field type is also changed to a more efficient sfixed32 with
special-casing -1 as "value not known".
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-proto that referenced this issue Nov 25, 2019
Refine child span count field
75141cd 
The field was previously defined ambiguously and it was not clear
whether it was the count of local or all children (including remotely
generated).

This change makes it clear that this is only local children. A counter
of remote children may be added in the future if there is an understanding
about how to obtain this number (open discussion is here:
open-telemetry/opentelemetry-specification#355).

The field type is also changed to a more efficient sfixed32 with
special-casing -1 as "value not known".
@tigrannajaryan tigrannajaryan mentioned this issue Nov 25, 2019
Merged
@jmacd jmacd changed the title Clarify what information about child cound Span data should carry Clarify what information about child count Span data should carry Nov 25, 2019
@jmacd jmacd mentioned this issue Nov 26, 2019
Merged
SergeyKanzhelev pushed a commit to open-telemetry/opentelemetry-proto that referenced this issue Nov 26, 2019
@tigrannajaryan @SergeyKanzhelev
Refine child span count field (#72)
28b0e42 
The field was previously defined ambiguously and it was not clear
whether it was the count of local or all children (including remotely
generated).

This change makes it clear that this is only local children. A counter
of remote children may be added in the future if there is an understanding
about how to obtain this number (open discussion is here:
open-telemetry/opentelemetry-specification#355).

The field type is also changed to a more efficient sfixed32 with
special-casing -1 as "value not known".
@jmacd jmacd mentioned this issue Dec 23, 2019
Closed
@bogdandrutu bogdandrutu added the spec:trace Related to the specification/trace directory label Jun 12, 2020
@reyang reyang added the area:api Cross language API specification issue label Jun 30, 2020
@carlosalberto carlosalberto added the release:after-ga Not required before GA release, and not going to work on before GA label Jul 2, 2020
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
@reyang
add lalitb and ThomsonTan as approvers (open-telemetry#355)
1b2c78f
@jmacd jmacd mentioned this issue Jan 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:api Cross language API specification issue release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@carlosalberto @Oberon00 @bogdandrutu @tigrannajaryan @reyang