Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a statsd exporter standard in the spec #374

Closed
naseemkullah opened this issue Dec 6, 2019 · 6 comments
Closed

Consider adding a statsd exporter standard in the spec #374

naseemkullah opened this issue Dec 6, 2019 · 6 comments
Labels
spec:metrics Related to the specification/metrics directory

Comments

@naseemkullah
Copy link
Member

Any plan to add a statsd exporter for metrics?

@jmacd
Copy link
Contributor

jmacd commented Dec 6, 2019

(I can't speak for the community here, but I've been involved in the SDK specification.)

The original project v1.0 scope did not mention a statsd exporter. The challenges with statsd are:
(1) that there is not a firm specification for it
(2) if using "plain" statsd, there's not a well-established (standard) way to handle labels, e.g., see https://github.com/prometheus/statsd_exporter
(3) if using "dogstatsd" statsd, the specification is still not very clear, but at least we know how to handle labels

@cory-signalfx has spoken up about this, see open-telemetry/opentelemetry-proto#59 (comment)

In the Go SDK I've included a common statsd implementation and a dogstatsd exporter, but there are questions about whether dogstatsd qualifies as vendor support (if it does not use the datadog client), especially considering there are open-source implementations of dogstatsd.

If you're interested in helping out, particularly if you're looking for "plain" statsd support and want to talk about how to handle labels, I'm interested.

@jmacd
Copy link
Contributor

jmacd commented Dec 6, 2019

See https://github.com/open-telemetry/opentelemetry-go/tree/master/exporter/metric/dogstatsd

@jmacd jmacd added the spec:metrics Related to the specification/metrics directory label Dec 12, 2019
@jmacd jmacd changed the title statsd Consider adding a statsd exporter standard in the spec Feb 20, 2020
@jmacd
Copy link
Contributor

jmacd commented Feb 20, 2020

The reason we can't do this is that statsd (and dogstatsd) do not have a formal specification.

@jmacd
Copy link
Contributor

jmacd commented Feb 20, 2020

@jbarciauskas I've asked in the past whether DataDog is interested in producing a specification.

@jmacd
Copy link
Contributor

jmacd commented Mar 24, 2020

We will not pursue a statsd implementation until there is a specification to follow. Let's revisit this discussion when there is a specification to follow.

@pauldraper
Copy link

pauldraper commented Feb 20, 2022

The StatsD spec is here: https://github.com/statsd/statsd#usage https://github.com/statsd/statsd/blob/master/docs/metric_types.md and has been for a decade.

If you're looking for some overwrought thing with 5000 minimum word count, you'll be disappointed; the beauty of StatsD is in the utter simplicity and clarity of its specification. So much so that countless vendors have found it suitable to build on.

(Speaking of Datadog, they did add an extension to StatsD for "tags." That's obviously is not included.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

No branches or pull requests

3 participants