-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we support fractional count in SummaryValue #59
Comments
Common statsd metrics APIs support entering metric updates with a weight. We have not discussed type of support at the API level, but at the protocol level it seems more important to consider now. The use I have in mind is generating metric summaries from a stream of spans. If the spans are sampled, they may have non-integer counts. I would connect this issue with open-telemetry/opentelemetry-specification#180. |
@jmacd Can you please post a relevant link here? |
(hello, first time talker) There's not a real spec for StatsD, but insofar as there are de facto standards this is a reasonable one. Here is the sampling for counters. I know at least Stripe's Veneur supports a sample rate on histograms too… |
For example, the Datadog statsd Count method contains a float64 "rate" parameter. In the statsd protocol, the count and sample rate are reported as separate fields. It would be reasonable, at least for discussing Summary values, to keep an integer count and a total sample weight adjustment as a separate multiplier. I'm starting to think we should close this. |
@cory-signalfx on the topic of statsd specifications, (sorry this is off-topic), do you know of any standard documents used by Veneur for the dogstatsd syntax for metric labels? I'm looking for comments to finish out open-telemetry/opentelemetry-go#326 I'd like to discuss this sort of thing with you in https://gitter.im/open-telemetry/metrics-specs, thanks. |
Closing this in favor of #73. |
See discussion here #51 (comment)
The text was updated successfully, but these errors were encountered: