Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the metrics that we expect to capture from RPC integrations #522

Closed
mtwo opened this issue Mar 20, 2020 · 5 comments
Closed

Define the metrics that we expect to capture from RPC integrations #522

mtwo opened this issue Mar 20, 2020 · 5 comments
Labels
area:semantic-conventions Related to semantic conventions priority:p2 Medium priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Milestone

Comments

@mtwo
Copy link
Member

mtwo commented Mar 20, 2020

This is out of scope for beta, in scope for RC and beyond

While we have (somewhat) clear expectations of the spans and annotations that we expect tracing integrations to capture from RPC clients and servers, this isn't the case for metrics integrations. I propose that RPC integrations should capture the following metrics by default:

  • Request / response latency, in milliseconds
  • Throughput, in queries per second, broken down by status / response code
@mtwo mtwo added the spec:metrics Related to the specification/metrics directory label Mar 20, 2020
@mtwo mtwo added this to the v0.5 milestone Mar 20, 2020
@fbogsany
Copy link
Contributor

Errors per second?

@mtwo
Copy link
Member Author

mtwo commented Mar 25, 2020

@fbogsany would queries per second with aggregation by status code (or equivalent) satisfy that?

@Oberon00
Copy link
Member

I think there are many metrics that could be generated on the back end out of the received spans & traces. Duplicating these metrics on the client side might be helpful in case we sample though.

@mtwo
Copy link
Member Author

mtwo commented Mar 27, 2020

@fbogsany edited the issue to specify that QPS metrics should be broken down by status code
@Oberon00 edited the issue to specify that this should be done for clients and servers

@carlosalberto carlosalberto modified the milestones: v0.5, v0.6 Jun 9, 2020
@carlosalberto carlosalberto added the area:api Cross language API specification issue label Jun 26, 2020
@jmacd jmacd added the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Jun 29, 2020
@mtwo mtwo added this to Required for GA in GA Burndown Jun 29, 2020
@mtwo mtwo added this to Required for GA, needs action. Add label:release:required-for-ga to issues and PRs when moving them to this column. in GA Spec Burndown Jun 29, 2020
@bogdandrutu bogdandrutu added the priority:p2 Medium priority level label Jul 24, 2020
@Oberon00 Oberon00 added area:semantic-conventions Related to semantic conventions and removed area:api Cross language API specification issue labels Oct 13, 2020
@bogdandrutu
Copy link
Member

Closing this as a duplicate of #1016

GA Spec Burndown automation moved this from Required for GA, needs action. Add label:release:required-for-ga to issues and PRs when moving them to this column. to Required for GA, done Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions priority:p2 Medium priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
No open projects
GA Burndown
  
Required for GA; add release:required...
GA Spec Burndown
  
Required/Allowed for GA, resolved.
Development

No branches or pull requests

6 participants