Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define metric semantic conventions for RPC #1016

Closed
jgals opened this issue Sep 25, 2020 · 3 comments · Fixed by #1162
Closed

Define metric semantic conventions for RPC #1016

jgals opened this issue Sep 25, 2020 · 3 comments · Fixed by #1162
Assignees
@jsuereth @jgals
Labels
area:semantic-conventions Related to semantic conventions priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory
Projects
GA Spec Burndown

Comments

@jgals
Copy link

jgals commented Sep 25, 2020

What are you trying to achieve?
Documented metric semantic conventions for remote procedure calls (RPC).

What did you expect to see?
Metric semantic conventions for RPC documented in markdown generated from YAML definitions as per #547.

Additional context.
These should be roughly analogous to the trace semantic conventions for RPC defined here. For reference, metric semantic conventions for HTTP operations are already defined here.
@jgals jgals added the spec:metrics Related to the specification/metrics directory label Sep 25, 2020
@arminru arminru added the area:semantic-conventions Related to semantic conventions label Sep 25, 2020
@andrewhsu andrewhsu added priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Oct 2, 2020
@andrewhsu andrewhsu added this to Required for GA, needs action. Add label:release:required-for-ga to issues and PRs when moving them to this column. in GA Spec Burndown Oct 6, 2020
@jgals
Copy link
Author

jgals commented Oct 6, 2020 •
edited
Loading

@aabmass would you, or another contributor from Google, be interested in working on a draft PR to address this issue?

@Oberon00
Copy link
Member

Oberon00 commented Oct 13, 2020 •
edited
Loading

Duplicate of #522 (I think), which was triaged (long ago, I guess) as P2.

@andrewhsu andrewhsu added priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs and removed priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Oct 16, 2020
@bogdandrutu bogdandrutu mentioned this issue Oct 16, 2020
Closed
@jsuereth
Copy link
Contributor

I'm taking a look at this this week, can you assign this to me?

jsuereth added a commit to jsuereth/opentelemetry-specification that referenced this issue Oct 30, 2020
@jsuereth
Fixes open-telemetry#1016: Define RPC semantic conventions for metrics.
63041a7
@jsuereth jsuereth mentioned this issue Oct 30, 2020
Merged
@andrewhsu andrewhsu moved this from Required/Allowed for GA, todo. to Required/Allowed for GA, with linked PR. in GA Spec Burndown Oct 30, 2020
jsuereth added a commit to jsuereth/opentelemetry-specification that referenced this issue Nov 10, 2020
@jsuereth
Fixes open-telemetry#1016: Define RPC semantic conventions for metrics.
61f057a
jsuereth added a commit to jsuereth/opentelemetry-specification that referenced this issue Nov 24, 2020
@jsuereth
Fixes open-telemetry#1016: Define RPC semantic conventions for metrics.
5e3cf6e
GA Spec Burndown automation moved this from Required/Allowed for GA, with linked PR. to Required/Allowed for GA, resolved. Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsuereth jsuereth

@jgals jgals

Labels
area:semantic-conventions Related to semantic conventions priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory
Projects
No open projects
GA Spec Burndown
  
Required/Allowed for GA, resolved.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide semantic conventions for RPC metrics jsuereth/opentelemetry-specification
5 participants
@jsuereth @andrewhsu @Oberon00 @arminru @jgals