Add prometheus exporter env vars #1021
Conversation
| | Name | Description | Default | | ||
| | ----------------------------- | --------------------------------| ---------------------------- | | ||
| | OTEL_EXPORTER_PROMETHEUS_HOST | Host of the Prometheus exporter | All addresses: "0.0.0.0" | | ||
| | OTEL_EXPORTER_PROMETHEUS_PORT | Port of the Prometheus exporter | 9496 | |
There was a problem hiding this comment.
Shall we use the same port across instrumentations? This port is from the JS SDK.
https://github.com/prometheus/prometheus/wiki/Default-port-allocations
https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-exporter-prometheus
There was a problem hiding this comment.
As 9496 is reserved port in Prometheus as per above links, I think it is a bad idea to use it here by default
There was a problem hiding this comment.
My bad, I made a typo. I wanted to propose 9464 which is assigned to OTel JS exporter (see the link above). We could rename it in the p8s docs that it applies for all OTEL SDKs.
There was a problem hiding this comment.
This is a VERY good idea :)
|
Once merged I will update https://github.com/prometheus/prometheus/wiki/Default-port-allocations to reflect that the port applies to all OTEL SDKs. |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
force-pushed
the
prometheus-exporter
branch
from
5d42f68
to
3015c5d
Compare
|
@bogdandrutu rebased |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Pavol Loffay ploffay@redhat.com
Changes
Add prometheus exporter env vars.
Related issues
open-telemetry/opentelemetry-java-instrumentation#385