Trace API: Update mentions of SpanContext as parent. #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
added
area:api
arminru
reviewed
Sep 28, 2020
carlosalberto
approved these changes
Sep 28, 2020
|
Overall LGTM (as it is an editorial change). Please apply @arminru's feedback. |
carlosalberto
added
the
release:allowed-for-ga
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
arminru
approved these changes
Sep 28, 2020
bogdandrutu
reviewed
Sep 28, 2020
|
I realized that we can be far less vague in this section now and rewrote it. |
bogdandrutu
approved these changes
Sep 29, 2020
jkwatson
reviewed
Sep 29, 2020
SergeyKanzhelev
approved these changes
Sep 29, 2020
Co-authored-by: John Watson <jkwatson@gmail.com>
arminru
approved these changes
Sep 30, 2020
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
SpanContextas parent for the situation after only allowingContextas parent (Spans's parent must be passed as Context instead of Span(Context)s. #875) and not allowing to storeSpanContextdirectly inContext/ introducing Propagated Span (Define Propagation-only Span to simplify active Span logic in Context. #994).This should be only an editorial change, there is no intent to change meaning, thus no CHANGELOG update.