Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge SpanContext into Span #1033

Closed
wants to merge 13 commits into from
Closed

Merge SpanContext into Span #1033

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d4621cf
Remove SpanContext in favor of having identifiers directly on the Spa…
Sep 29, 2020
c350104
Lint
Sep 29, 2020
78c0575
Update specification/overview.md
Sep 29, 2020
e6cdecf
Some cleanup
Sep 29, 2020
51d0a72
Merge branch 'remove-spancontext' of github.com:anuraaga/opentelemetr…
Sep 29, 2020
b303a4f
Remove 'span identifiers'
Oct 2, 2020
d85bfbd
Merge branch 'master' of github.com:open-telemetry/opentelemetry-spec…
Oct 2, 2020
7846bc2
Lint
Oct 2, 2020
1339a0f
Clean
Oct 2, 2020
188a71e
Apply suggestions from code review
Oct 2, 2020
811329e
Cleanups
Oct 2, 2020
5979193
Merge branch 'remove-spancontext' of github.com:anuraaga/opentelemetr…
Oct 2, 2020
d2a23b2
IsRemote means span ID not generated
Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification/context/api-propagators.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ Injects the value into a carrier. For example, into the headers of an HTTP reque
Required arguments:

- A `Context`. The Propagator MUST retrieve the appropriate value from the `Context` first, such as
`SpanContext`, `Baggage` or another cross-cutting concern context.
`Span`, `Baggage` or another cross-cutting concern context.
- The carrier that holds the propagation fields. For example, an outgoing message or HTTP request.

#### Extract
Expand All @@ -93,7 +93,7 @@ Required arguments:
- The carrier that holds the propagation fields. For example, an incoming message or http response.

Returns a new `Context` derived from the `Context` passed as argument,
containing the extracted value, which can be a `SpanContext`,
containing the extracted value, which can be a `Span`,
`Baggage` or another cross-cutting concern context.

## TextMap Propagator
Expand Down
19 changes: 6 additions & 13 deletions specification/overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ Table of Contents
- [Distributed Tracing](#distributed-tracing)
* [Trace](#trace)
* [Span](#span)
* [SpanContext](#spancontext)
* [Links between spans](#links-between-spans)
- [Metrics](#metrics)
* [Recording raw measurements](#recording-raw-measurements)
Expand Down Expand Up @@ -96,15 +95,10 @@ Each **Span** encapsulates the following state:
- A set of zero or more **Events**, each of which is itself a tuple (timestamp, name, [**Attributes**](./common/common.md#attributes)). The name must be strings.
- Parent's **Span** identifier.
- [**Links**](#links-between-spans) to zero or more causally-related **Spans**
(via the **SpanContext** of those related **Spans**).
- **SpanContext** identification of a Span. See below.
- Span's propagated information. See below.

### SpanContext

Represents all the information that identifies **Span** in the **Trace** and
MUST be propagated to child Spans and across process boundaries. A
**SpanContext** contains the tracing identifiers and the options that are
propagated from parent to child **Spans**.
A **Span** has the following identifiers and options which MUST be propagated to child Spans
and across process boundaries. These are propagated from parent to child **Spans**.

- **TraceId** is the identifier for a trace. It is worldwide unique with
practically sufficient probability by being made as 16 randomly generated
Expand All @@ -125,9 +119,8 @@ propagated from parent to child **Spans**.

### Links between spans

A **Span** may be linked to zero or more other **Spans** (defined by
**SpanContext**) that are causally related. **Links** can point to
**SpanContexts** inside a single **Trace** or across different **Traces**.
A **Span** may be linked to zero or more other **Spans** that are causally related.
**Links** can point to **Spans** inside a single **Trace** or across different **Traces**.
**Links** can be used to represent batched operations where a **Span** was
initiated by multiple initiating **Spans**, each representing a single incoming
item being processed in the batch.
Expand Down Expand Up @@ -280,7 +273,7 @@ See the [Context](context/context.md)
## Propagators

OpenTelemetry uses `Propagators` to serialize and deserialize cross-cutting concern values
such as `SpanContext` and `Baggage`. Different `Propagator` types define the restrictions
such as `Span` and `Baggage`. Different `Propagator` types define the restrictions
imposed by a specific transport and bound to a data type.

The Propagators API currently defines one `Propagator` type:
Expand Down