Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a directive that the Baggage API must function, even without an SDK. #1103

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Add a directive that the Baggage API must function, even without an SDK. #1103

merged 3 commits into from
Oct 20, 2020

Conversation

jkwatson
Copy link
Contributor

Fixes #1070

Changes

Clarifies that the Baggage API MUST be functional with only the OpenTelemetry API, without an installed SDK.

@jkwatson jkwatson requested review from a team as code owners October 16, 2020 21:12
@jkwatson jkwatson changed the title Add a directive that the Baggage API must function, even without an SDk. Add a directive that the Baggage API must function, even without an SDK. Oct 16, 2020
@jkwatson jkwatson mentioned this pull request Oct 16, 2020
Merged
@carlosalberto carlosalberto self-requested a review October 17, 2020 17:26
@carlosalberto
Copy link
Contributor

cc @bogdandrutu

@Oberon00
Copy link
Member

IMHO we should not specify baggage as part of the API, if it is in fact not an API but API+SDK folded into one. It should rather be an independent module that exists next to the API and shares the context layer.

@jkwatson
Copy link
Contributor Author

IMHO we should not specify baggage as part of the API, if it is in fact not an API but API+SDK folded into one. It should rather be an independent module that exists next to the API and shares the context layer.

If you want to change this, I can let you take over the ownership of the issue. I don't think this is the right PR for your suggested change, whether or not I agree with it.

@jkwatson
Copy link
Contributor Author

6 approvals on this. Any reason not to merge?

@SergeyKanzhelev
Copy link
Member

6 approvals on this. Any reason not to merge?

mostly the 2 business days wait period requirement for PRs. I'd say let's merge tomorrow morning PST

@SergeyKanzhelev
Copy link
Member

there were no additional comments on spec meeting and two days passed. Merging,

@SergeyKanzhelev SergeyKanzhelev merged commit 12e3a4a into open-telemetry:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@arminru arminru arminru approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@reyang reyang reyang approved these changes

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What is the API behavior of Baggage in the absence of an SDK?
8 participants
@jkwatson @carlosalberto @Oberon00 @SergeyKanzhelev @anuraaga @bogdandrutu @arminru @reyang