Add OTEL_TRACE_SAMPLER_ARG env variable definition. #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
added
area:sdk
anuraaga
approved these changes
Nov 6, 2020
|
@open-telemetry/specs-approvers Please review this issue (will merge by EOD Monday). |
Oberon00
reviewed
Nov 9, 2020
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
arminru
approved these changes
Nov 9, 2020
tigrannajaryan
approved these changes
Nov 9, 2020
yurishkuro
reviewed
Nov 9, 2020
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
bogdandrutu
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1105
Closes #1190 (alternative solution)
Changes
It was discussed in the latest TC meeting trying out the approach taken by Jaeger, which uses two environment variables to configure samplers:
This way, each
Samplerwill use the same environment variable, and we could even extend the future expected input, i.e. accept json.