Specify Span ID creation with sampling (non-recording spans included) #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Conflicts: spec-compliance-matrix.md
carlosalberto
added
area:sdk
Oberon00
reviewed
Nov 13, 2020
There was a problem hiding this comment.
Comparison to the alternative PR #998: dynatrace-oss-contrib:sdk-spanid-sampling...carlosalberto:sdk-spanid-sampling
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
|
One point to consider: If we explicitly encourage users to rely on unsampled spans having an ID, we should probably close #864 "Option to allow "default" IDs for unsampled traces" as wontfix. CC @awssandra |
bogdandrutu
approved these changes
Nov 13, 2020
jkwatson
reviewed
Nov 13, 2020
Co-authored-by: John Watson <jkwatson@gmail.com>
yurishkuro
approved these changes
Nov 13, 2020
jmacd
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1060
Spin-off of #998 (closes #998)
After discussing pros and cons, it was recommended to always generate new Span Ids even for non-recording instances.
cc @yurishkuro @SergeyKanzhelev